Adds :append option to add values to the selection in :tags mode.#63
Closed
shamanime wants to merge 3 commits intomaxmarcon:mainfrom
Closed
Adds :append option to add values to the selection in :tags mode.#63shamanime wants to merge 3 commits intomaxmarcon:mainfrom
:append option to add values to the selection in :tags mode.#63shamanime wants to merge 3 commits intomaxmarcon:mainfrom
Conversation
Owner
|
Hi and sorry for replying so late... last months were extremely busy for me. So, why can't we just do this: send_update(LiveSelect.Component, id: live_select_id, value: current_selection ++ stuff_you_want_to_append)I really want to keep the API lean and as minimal as possible (there's already too many options IMO) so if this gets the job done I'd rather stick with it. |
Contributor
Author
|
Closed in favor of #68 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is motivated by our need to allow the user to add a preset list of values to a selection group at any moment without replacing already selected values.
This is the minimum code for it to work. Please let me know how it can be improved. :D